This repository was archived by the owner on Nov 13, 2025. It is now read-only.
gh-758: Adds benchmarks for functions in algorithm.py#16
Closed
connoraird wants to merge 5 commits intoconnor/issue-7from
Closed
gh-758: Adds benchmarks for functions in algorithm.py#16connoraird wants to merge 5 commits intoconnor/issue-7from
connoraird wants to merge 5 commits intoconnor/issue-7from
Conversation
paddyroddy
reviewed
Nov 11, 2025
connoraird
force-pushed
the
connor/issue-758
branch
from
ff1b593 to
1208fb1
Compare
paddyroddy
reviewed
Nov 12, 2025
paddyroddy
approved these changes
Nov 12, 2025
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding benchmarks for
glass.algorithmfunctions. Mostly these benchmarks are copies of the tests that exist in glass already. However, I have removed sad paths tests which exit early as I believe these are not as relevant for testing the performance of these functions in a working state.There is still work to be done for benchmarking
glass.algorithm.nnlsas this is not fully covered. Should be handled in glass-dev/glass#759Should probably wait for #14.